.. _classes-uselessassignationofpromotedproperty:

.. _useless-assignation-of-promoted-property:

Useless Assignation Of Promoted Property
++++++++++++++++++++++++++++++++++++++++

  Promoted properties save the assignation of constructor argument to the property. It is useless to do it with that syntax, and in the constructor too.

.. code-block:: php
   
   <?php
   
   class x {
   	private $b;
   	
   	function __construct(private $a,
   						 $b,						 
   						 ) {
   		// This is already done with the promoted property
   		$this->a = $a;
   
   		// This is the traditional way (up to PHP 8.0)
   		$this->b = $b;
   		}
   }
   
   ?>

Suggestions
___________

* Remove the assignation in the constructor




Specs
_____

+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Short name   | Classes/UselessAssignationOfPromotedProperty                                                                                                               |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Rulesets     | :ref:`All <ruleset-All>`, :ref:`Analyze <ruleset-Analyze>`, :ref:`Changed Behavior <ruleset-Changed-Behavior>`, :ref:`Class Review <ruleset-Class-Review>` |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Exakat since | 2.5.0                                                                                                                                                      |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| PHP Version  | With PHP 8.0 and more recent                                                                                                                               |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Severity     | Minor                                                                                                                                                      |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Time To Fix  | Quick (30 mins)                                                                                                                                            |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Precision    | Very high                                                                                                                                                  |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Features     | promoted-property                                                                                                                                          |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Available in | `Entreprise Edition <https://www.exakat.io/entreprise-edition>`_, `Exakat Cloud <https://www.exakat.io/exakat-cloud/>`_                                    |
+--------------+------------------------------------------------------------------------------------------------------------------------------------------------------------+