1.2.735. Multiple Property Declaration¶
The same property is declared in various classes, at least two, in the same class hierarchy. The declarations must be compatible one another, and one of them should be sufficient.
Generally, the higher declaration should be the one to stay.
Keeping one definition makes it clear which class is responsible for that property. It also keep the code more flexible in case of an update on the property: only one place to change it.
<?php
class x {
// redeclared in y
public $p = 1;
// declared only in x;
public $q;
}
class y extends x {
// redeclared in x
public $p = 2;
// declared only in y;
public $q;
}
?>
1.2.735.1. Suggestions¶
Remove all but one of the declarations
Change the name of some of the properties, to keep their meaning separate
1.2.735.2. Specs¶
Short name |
Classes/MultiplePropertyDeclaration |
Rulesets |
|
Exakat since |
2.6.4 |
PHP Version |
All |
Severity |
Minor |
Time To Fix |
Quick (30 mins) |
Precision |
Very high |
Features |
dry |
Available in |