1.2.1259. Uninitialized Property¶
Uninitialized properties are not fully bootstrapped at the end of the constructor.
Properties may be initialized at definition time, along with their visibility and type. Some types are not initialized at definition time, as any object (before PHP 8.2) or resources, so they should be initialized during constructor. At the end of the former, all properties shall have a legit value, and be ready for usage.
PHP 8.1 introduced the possibility to instantiate objects as default value, as long as they only require constant values. This means that those properties may have an object type and a default value.
<?php
class x {
private $foo = null;
private $uninited;
function __construct($arg) {
$this->foo = $args;
// $this->uninited is not inited, nor at definition, nor in constructor
// it will hold null at the beginning of the next method call
}
}
?>
1.2.1259.1. Suggestions¶
Remove the property, and move it to another class
Add an initialisation for this property
Give the property a neutral value (object or scalar)
1.2.1259.2. Specs¶
Short name |
Classes/UninitedProperty |
Rulesets |
|
Exakat since |
2.0.9 |
PHP Version |
All |
Severity |
Minor |
Time To Fix |
Quick (30 mins) |
Precision |
Medium |
Features |
property, default-value |
Available in |