1.2.732. Multiple Identical Closure¶
Several closures are defined with the same code.
It may be interesting to check if a named function could be defined from them. This analysis also reports functions and methods that look like the closures : they may be considered for switch.
<?php
// the first squares, with closure
$squares= array_map(function ($a) {return $a * $a; }, range(0, 10) );
// later, in another file...
// another identical closure
$squaring = function ($x) { return $x * $x; };
foo($x, $squaring);
?>
See also class.
1.2.732.1. Suggestions¶
Create a function with the body of those closures, and replace the closures by the function’s name.
1.2.732.2. Specs¶
Short name |
Functions/MultipleIdenticalClosure |
Rulesets |
|
Exakat since |
1.5.8 |
PHP Version |
All |
Severity |
Minor |
Time To Fix |
Slow (1 hour) |
Precision |
Medium |
Features |
class |
Available in |