1.2.1317. Use Constant As Arguments

Some methods and functions are defined to be used with constants as arguments. Those constants are made to be meaningful and readable, keeping the code maintenable. It is recommended to use such constants as soon as they are documented.

Here is the list of functions that use a unique PHP constant as argument :

• array_change_key_case()

• array_multisort()

• array_unique()

• count()

• dns_get_record()

• easter_days()

• extract()

• filter_input()

• filter_var()

• fseek()

• get_html_translation_table()

• gmp_div_q()

• gmp_div_qr()

• gmp_div_r()

• html_entity_decode()

• htmlspecialchars_decode()

• http_build_query()

• http_parse_cookie()

• http_parse_params()

• http_redirect()

• http_support()

• parse_ini_file()

• parse_ini_string()

• parse_url()

• pathinfo()

• pg_select()

• posix_access()

• round()

• scandir()

• socket_read()

• str_pad()

• trigger_error()

Here is the list of functions that use a combination of PHP native constants as argument.

• arsort()

• asort()

• error_reporting()

• filter_input()

• filter_var()

• get_html_translation_table()

• htmlentities()

• htmlspecialchars()

• http_build_url()

• jdtojewish()

• krsort()

• ksort()

• pg_result_status()

• phpcredits()

• phpinfo()

• preg_grep()

• preg_match()

• preg_split()

• rsort()

• runkit_import()

• sort()

• stream_socket_client()

• stream_socket_server()

<?php

// Turn off all error reporting
// 0 and -1 are accepted
error_reporting(0);

// Report simple running errors
error_reporting(E_ERROR | E_WARNING | E_PARSE);

// The first argument can be one of INPUT_GET, INPUT_POST, INPUT_COOKIE, INPUT_SERVER, or INPUT_ENV.
$search_html = filter_input(INPUT_GET, 'search', FILTER_SANITIZE_SPECIAL_CHARS);

// sort accepts one of SORT_REGULAR, SORT_NUMERIC, SORT_STRING, SORT_LOCALE_STRING, SORT_NATURAL
// SORT_FLAG_CASE may be added, and combined with SORT_STRING or SORT_NATURAL
sort($fruits);

?>

1.2.1317.1. Suggestions

• Use PHP native constants, whenever possible, instead of nondescript literals.

1.2.1317.2. Specs

Short name	Functions/UseConstantAsArguments
Rulesets	All, Analyze, CE, CI-checks
Exakat since	0.8.4
PHP Version	All
Severity	Major
Time To Fix	Quick (30 mins)
Precision	High
Examples	Tikiwiki, shopware
Available in	Entreprise Edition, Community Edition, Exakat Cloud