1.2.1319. Use Constants As Returns

When a native PHP function returns only constants, it is recommended to use those constants to identify the returned values.

<?php

if (preg_last_error() != PREG_NO_ERROR ) {
    // An error occured with the last Regex call
}

// Who will guess PREG_JIT_STACKLIMIT_ERROR ?
if (preg_last_error() == 6 ) {
    // An error occured with the last Regex call
}

?>

1.2.1319.1. Suggestions

  • Use the valid constants to identify the results

1.2.1319.2. Specs

Short name

Functions/UseConstantsAsReturns

Rulesets

All, Analyze

Exakat since

2.3.9

PHP Version

All

Severity

Minor

Time To Fix

Quick (30 mins)

Precision

High

Available in

Entreprise Edition, Exakat Cloud