1.2.282. Could Merge Ternary Into Ifthen

When two ternary operators are used, in succession, with the same condition, it might be more readable to write it as an if then condition.

With an if then structure, the related instructions are grouped together, while they are scattered otherwise.

Readability improves with more ternaries in a row.

<?php

$variable1 = $a ? 'b0' : $c;
$variable2 = $a ? foo() : null;

if ($a) {
     $variable1 = 'b0';
     $variable2 = foo();
} else {
     $variable1 = $c;
     $variable2 = null;
}

?>

1.2.282.1. Connex PHP features

1.2.282.1.1. Specs

Short name

Structures/MergeTernaryIntoIfthen

Rulesets

All, Analyze

Exakat since

2.6.8

PHP Version

All

Severity

Minor

Time To Fix

Quick (30 mins)

Precision

High

Available in

Entreprise Edition, Exakat Cloud